Add long explanation for E0726 #94449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
Urgau
requested changes
Feb 28, 2022
| lifetime of the `content` can differ from current context: | ||
|
|
||
| ```ignore (needs futures dependency) | ||
| async fn create(content: Content) { // ok! |
There was a problem hiding this comment.
How is that different from the example above who didn't compile ? Did you mean to write ?
Suggested change
| async fn create(content: Content) { // ok! | |
| async fn create<'a>(content: Content<'a>) { // ok! |
There was a problem hiding this comment.
Oups, good catch!
There was a problem hiding this comment.
I meant to write:
async fn create(content: Content<'_>) {| When a struct or a type is bound/declared with a lifetime it is important for | ||
| the Rust compiler to know, on usage, the lifespan of the type. When the | ||
| lifetime is not explicitly mentioned and the Rust Compiler cannot determine | ||
| the lifetime of your type the following error occurs. |
There was a problem hiding this comment.
Suggested change
| the lifetime of your type the following error occurs. | |
| the lifetime of your type, the following error occurs. |
GuillaumeGomez
force-pushed
the
explanation-e0726
branch
from
e18ab11
to
8f36d4a
Compare
Urgau
approved these changes
Feb 28, 2022
|
Thanks for the quick review! @bors: r=Urgau rollup |
|
📌 Commit 8f36d4a has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 28, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#92399 (fix typo in btree/vec doc: Self -> self) - rust-lang#92823 (Tweak diagnostics) - rust-lang#94248 (Fix ICE when passing block to while-loop condition) - rust-lang#94414 (Fix ICE when using Box<T, A> with large A) - rust-lang#94445 (4 - Make more use of `let_chains`) - rust-lang#94449 (Add long explanation for E0726) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cleaned up version of #87655 with the missing fixes.
Part of #61137.
r? @Urgau